Config files for new catalogs #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yymao
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Thanks @evevkovacs. If roman_rubin_v1.1.1_elais is deprecated (as indicated by README), can you add the deprecated tag to its config file?
|
@yymao I added the deprecated tag as requested and updated the information in the skysim_v3.1* yaml files to point to the newer roman_rubin catalog. |
|
Is it ok to merge, now that it's approved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the configuration files for the catalog used for the roman-desc simulations (v_1.1.2) and a newer variant with improved model parameters tuned against Cosmos2020 data.
These catalogs are in the shared catalogs area and the configuration files have been tested with DESCQA. See dn/dmag test